Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http): Implement soft and hard TTL for all cache providers #33904

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Jan 28, 2025

Changes

  • Move TTL logic to abstract provider
  • For repository cache, set soft ttl to zero, and hart TTL to 365 days
  • For package cache, nothing changes
  • Don't require cache to have at least one of etag or lastModified, now they're optional (useful for future memory cache implementation)

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov marked this pull request as draft January 28, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant