feat(cache): Make http cache providers respect cache-control header
#33848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Jan 26, 2025
No, current functionality will work as ususal |
viceice
reviewed
Jan 26, 2025
Comment on lines
+54
to
+59
| const isPublic = resp.headers?.['cache-control'] | ||
| ?.toLocaleLowerCase() | ||
| .split(regEx(/\s*,\s*/)) | ||
| .includes('public'); | ||
|
|
||
| return !isPublic; |
There was a problem hiding this comment.
I think we should allow caching if the header is missing 🤔
we should first add some logging and track some stats in the hosted app. so we're sure most ecosystems behave properly. and if not we need config options to workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds support for skipping cache when
cache-controlresponse header miss thepublicvalue.Since it doesn't make too much sense for repository cache, it's disabled.
But for package-level caching it's important to separate private packages, so it's enabled for package cache provider by default.
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: