Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github-actions): Use schema for dependency extraction #33584

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zharinov
Copy link
Collaborator

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice changed the title feat(github): Use schema for dependency extraction feat(github-actions): Use schema for dependency extraction Jan 13, 2025
@zharinov zharinov requested a review from viceice January 22, 2025 18:46
@zharinov zharinov requested a review from rarkins January 22, 2025 18:46
@viceice viceice added this pull request to the merge queue Jan 30, 2025
@viceice viceice removed this pull request from the merge queue due to a manual request Jan 30, 2025
);
return [];
}
const jobs = WorkflowJobsSchema.parse(content);
Copy link
Member

@viceice viceice Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add some error logging, so we know if parsing fails (probably of some github schema changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants