Fixed replace-id to prevent stack overflow on self-referencing types
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eagle941
force-pushed
the
stack_overflow_ids
branch
4 times, most recently
from
8ef8e3f to
fcf36cc
Compare
Eagle941
force-pushed
the
stack_overflow_ids
branch
from
fcf36cc to
52fbdbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug reported in #54.
The stack overflow error is fixed by avoiding infinite calls to the function
replace_type_id. A cycle detection strategy is used to detect self-referencing types and stop recursion.A new test proves that the changes are working.