Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Check* Hooks #963

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Implement Check* Hooks #963

wants to merge 26 commits into from

Conversation

JohanCorn
Copy link

  • CheckGameOver
  • CheckTimeLimit
  • CheckFragLimit
  • CheckMaxRounds
  • CheckWinLimit

@JohanCorn
Implement Check* Hooks
190ceec 
- CheckGameOver
- CheckTimeLimit
- CheckFragLimit
- CheckMaxRounds
- CheckWinLimit
@dystopm
Copy link
Contributor

dystopm commented May 25, 2024

Question, why are you declaring hook function as VFUNC?

@JohanCorn
Copy link
Author

Question, why are you declaring hook function as VFUNC?

I made a mistake, but thank you for pointing it out.

@JohanCorn JohanCorn marked this pull request as draft May 25, 2024 23:40
@dystopm dystopm mentioned this pull request Jun 1, 2024
Open
@JohanCorn
Copy link
Author

Question, why are you declaring hook function as VFUNC?

I have changed the VFUNC BOOL declarations to BOOL. However, I'm not sure if it is also necessary to change the bool type BOOL (int) as I did. Could you please review this aspect as well? Thank you!

@JohanCorn JohanCorn marked this pull request as ready for review June 11, 2024 08:41
@s1lentq s1lentq force-pushed the master branch 4 times, most recently from a363cba to 79cfd71 Compare July 14, 2024 19:18
s1lentq and others added 17 commits August 16, 2024 09:53
@s1lentq
Implemented simple player movement version control to avoid desync
8b6d659 
Bump minor API version
@s1lentq
Fix linux build
a8fd512
@s1lentq
remove unnecessary version consistency for some player movement code
12f4e9b
@s1lentq
[skip ci] VisualStudio: Add auto visualizer for some structures/classes
dc16b12
@Vaqtincha
fix mp_kill_filled_spawn (rehlds#1011)
3cf66de
@s1lentq
get rid of unsafe string functions
19714af 
minor refactor
@s1lentq
DeathSound: Don't interrupt pain sounds with death sound, use any ava…
3f628ea 
…ilable channel instead
@Vaqtincha
escape feature for bots (rehlds#1012)
9b7b169
@Vaqtincha
add desc to readme (rehlds#1014)
9b626b1
@Nord1cWarr1or
client.cpp: Use macros for pfnPrecacheEvent (rehlds#1019)
535ea84
@SergeyShorokhov @s1lentq
CI Workflow Refactor and Fixes (rehlds#1016)
7738142 
chore(ci): standardize and update CI workflows for compatibility and consistency

- Updated action versions (`checkout@v4`, `upload-artifact@v4`, `download-artifact@v4`) for enhanced compatibility and security
- Removed unsecure Node.js version allowance to align with *-latest OS requirements
- Migrated test demos to `rehldsorg/testdemos:latest` container with a streamlined testing approach via matrix strategy and `runTest.sh`
- Standardized Linux dependency installation for consistent build environment across jobs
- Unified CI workflow structure with `rehlds` and `regamedll` repositories for better consistency
- Optimized artifact deployment steps and removed unnecessary cleanup operations

Co-authored-by: s1lentq <[email protected]>
@s1lentq
fix typo
476b5f7
@s1lentq
Disable broken angle adjustment with throw direction in Killed to avo…
df7944a 
…id player model visual artifacts
@s1lentq
Removed -bots and -host-improve command line params in favor of using…
942f2e6 
… CVars
@s1lentq
AUG/SG552: Reset maxspeed when zooming
3efc5ad
@s1lentq
always consider all human players on the server to use bot_auto_vacat…
8a77bba 
…e correctly
@s1lentq
fixed issues reported by static analyzer
6f0d17b
@dystopm
Copy link
Contributor

dystopm commented Jan 9, 2025

Question, why are you declaring hook function as VFUNC?

I have changed the VFUNC BOOL declarations to BOOL. However, I'm not sure if it is also necessary to change the bool type BOOL (int) as I did. Could you please review this aspect as well? Thank you!

Sorry for the late answer. Don't use BOOL, because it is the same as int, and they will not matching origin structure size (int=4, bool=1), leading to unexpected behaviour with addons. Original functions return type were bool -> keep bool :)

@JohanCorn
Implement Check* Hooks
07c843d 
- CheckGameOver
- CheckTimeLimit
- CheckFragLimit
- CheckMaxRounds
- CheckWinLimit
@JohanCorn
Update gamerules.h
fe50005
@JohanCorn
Merge branch 'Implement-Check-Hooks' of https://github.com/JohanCorn/…
de64fa6 
…ReGameDLL_CS into Implement-Check-Hooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@JohanCorn @dystopm @StevenKal @MysticDeathProject @jobmail @s1lentq @Vaqtincha @Nord1cWarr1or @SergeyShorokhov