Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scripts): Args type for script arguments #11946

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Feb 5, 2025

  • Update the script template to include types
  • Improve comments to be more clear
  • Comment line to not start with red squiggles

@Tobbe Tobbe added the release:feature This PR introduces a new feature label Feb 5, 2025
@Tobbe Tobbe added this to the next-release milestone Feb 5, 2025
@Tobbe Tobbe enabled auto-merge (squash) February 5, 2025 19:51
@Tobbe Tobbe merged commit 33bfda8 into redwoodjs:main Feb 5, 2025
44 of 46 checks passed
@Tobbe Tobbe deleted the tobbe-script-template-types branch February 5, 2025 20:47
@Tobbe
Copy link
Member Author

Tobbe commented Feb 6, 2025

Very strange that this PR managed to auto-merge even when CI failed. That's not how it's supposed to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:feature This PR introduces a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant