Decouple menu expand and collapse from active item #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overall I really like this change. I haven't had much chance to go over code yet. |
|
Looking forward to this for #455! :) |
Blendify
reviewed
Feb 26, 2019
jessetan
added
Design
|
Is there any chance that this MR gets accepted anytime soon? Thanks |
|
@jessetan any chance that you can update this to master? And revert the changes to the background/hover colors. I am not against that change but rather it be in a separate PR. |
Conmemay200
reviewed
Jul 6, 2024
| @@ -114,7 +115,7 @@ function ThemeNav () { | |||
| var link = $(this); | |||
| expand = $('<span class="toctree-expand"></span>'); | |||
| expand.on('click', function (ev) { | |||
| self.toggleCurrent(link); | |||
| self.toggleExpanded(link); | |||
| ev.stopPropagation(); | |||
| return false; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to expand and collapse menu items independent of the current active item.
Before this, collapsing and expanding a menu item was coupled to the styling and logic that colored and highlighted the active item.
Makes hover colors and expand/collapse icon colors consistent over all menu items:
Expanding a non-active menu item no longer collapses the active menu item. Collapsing the active menu item no longer makes it look inactive.
Clicking the active item no longer makes it look inactive (Sidebar anchors double-click loose selection #306)
Adds some comments and slight cleanup of the menu CSS.
Fixes #306 amongst others. Prerequisite for #455.