Do not run djstripe checks on builders
#12159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We found this while performing the deploy. Builders do not have access to the database, and `djstripe` runs some checks that access the database to know if there are API keys defined there.
humitos
force-pushed
the
humitos/djstripe-builders
branch
from
67033fa to
abd1ca7
Compare
humitos
changed the title
djstripe on buildersdjstripe checks on builders
|
I'm hotfixing this now so I can finish the deploy we started yesterday. I'd appreciate a review here and any suggestion you may have since this is a hack for now to allow us to move forward with the original plan. |
stsewd
approved these changes
May 7, 2025
Co-authored-by: Santos Gallegos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found this while performing the deploy.
Builders do not have access to the database, and
djstriperuns some checksthat access the database to know if there are API keys defined there.
References: