Upgrade djstripe
#12148
Upgrade djstripe
#12148
Conversation
Closes #9706
> stripe.app_info, stripe.http_client, stripe.oauth, stripe.util, stripe.version, stripe.webhook, modules are deprecated. All types are available directly from stripe module now. https://github.com/stripe/stripe-python/blob/529167653d4203798b26ebfd08bc4788f009725c/CHANGELOG.md#780---2023-12-07
| @@ -430,16 +430,3 @@ def test_subscription_precedence(self): | |||
|
|
|||
| self.organization.refresh_from_db() | |||
| assert self.organization.stripe_subscription == stripe_subscription | |||
|
|
|||
| def test_register_events(self): | |||
There was a problem hiding this comment.
Doesn't look like we should delete these?
There was a problem hiding this comment.
I deleted it because "webhooks.registration" doesn't exist anymore. They deleted that file completely from the repository and I didn't find a replacement 🤷♂️
| regex | ||
|
|
||
| # NOTE: djstripe overrides the stripe api version |
There was a problem hiding this comment.
We should keep this note, but we use the stripe package directly in .org.
There was a problem hiding this comment.
The newer version says this is not like that anymore. There is a note in the release notes.
Maybe we should define it explicitly now?
There was a problem hiding this comment.
I didn't find any mention of that, can you link me to that?
There was a problem hiding this comment.
Yes. I'll share it once I get to my laptop
There was a problem hiding this comment.
It's under "Other changes" at https://github.com/dj-stripe/dj-stripe/releases/tag/2.8.0
stripe.api_version is no longer manipulated by dj-stripe.
|
I'm going to merge this PR now so we can deploy it today. @stsewd @ericholscher I would still appreciate any feedback you may have here. I also suppose we will fix anything we find during deploy, tho 😄 |
|
Hrm... corporate fails due I know that file was removed but I'm not sure what's the replacement, yet. I will investigate this. |
Closes #9706