-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Refactor: remove Version.documentation_type
#10042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
humitos
wants to merge
3
commits into
main
Choose a base branch
from
humitos/remove-documentation-type
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are planning to suppose _any_ doctool and we want to get rid of the `documentation_type` attribute and make our logic more generic to work on most scenarios without specific logic per doctool.
4 tasks
4 tasks
…mitos/remove-documentation-type
Summarizing the required changes here:
It seems the only blocker here is "understanding the logic behind the stripping of I think we are close to be able to move forward here. |
humitos
added a commit
that referenced
this pull request
Jun 30, 2023
This API is deprecated and nobody is currently using it. I checked this on Cloudflare and I didn't find people hitting this endpoint at all. Related #10042
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are planning to support any doctool and we want to get rid of the
documentation_type
attribute and make our logic more generic to work on most scenarios without specific logic per doctool.