Skip to content

Link to docs when project is private #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
Merged

Link to docs when project is private #587

merged 1 commit into from
May 2, 2025

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Apr 30, 2025

The other page where we talk about private repos is https://docs.readthedocs.com/platform/stable/guides/importing-private-repositories.html, but feels like the commercial page is better suited here.

@stsewd stsewd requested a review from a team as a code owner April 30, 2025 17:51
@stsewd stsewd requested a review from agjohnson April 30, 2025 17:51
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it's better than what is there. We could probably use a page or a modal explaining exactly what is happening at some point though.

@stsewd stsewd merged commit ca46240 into main May 2, 2025
4 checks passed
@stsewd stsewd deleted the link-to-something branch May 2, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants