favicon dev #530
Open
favicon dev #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ericholscher
commented
Nov 21, 2024
ericholscher
commented
- Revert "Revert "Fix button action on invite user page""
- Add favicon-dev so you can tell dev apart
ericholscher
added a commit
to readthedocs/readthedocs.org
that referenced
this pull request
Nov 21, 2024
Depends on readthedocs/ext-theme#530 I'm open to other favicons, just wanted something visible :)
|
@agjohnson is this missing anything or we can merge it? |
|
I mostly think there should just be one icon. In general, it's better that dev closely matches production. So, I'm not a particular fan of using a special favicon just for dev for that. I even prefer a single icon rather than differing icons for .org and .com. Browsers have profiles/multi-containers if it's really a trouble telling the tabs apart in dev. Ultimately this should use multiple sizes though. Browsers, search engines, and phones use all the various sizes and display gets odd on some of these without these definitions. We should match what we already do this on our website: That's easier with just a single icon style. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.