Make visibilitychange rotation an option #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
approved these changes
Oct 17, 2024
| @@ -457,7 +457,11 @@ const VIEWPORT_FUDGE_FACTOR = -3; // px | |||
| const MIN_VIEW_TIME_ROTATION_DURATION = 45; // seconds | |||
| const MAX_ROTATIONS = 3; | |||
|
|
|||
| // Enable ad rotation on hash change (intra-site nav) | |||
| const HASHCHANGE_ROTATION_ENABLE = true; | |||
There was a problem hiding this comment.
Would be nice if we could set this in the decision API response, so we could enable it dynamically, even per publisher 🤔
There was a problem hiding this comment.
I do like that idea. I'll probably skip it here but I'm going to be working on saving more ad rotation details in the server and that's a good time to work on those features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also disables visibilitychange rotations.