Skip to content

Vertically center the close button #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

davidfischer
Copy link
Contributor

A publisher reported the close (X) as slightly off center. Normally equal line-height to the element height does that correctly but not perfectly for this one character.

@davidfischer davidfischer requested review from a team and ericholscher June 3, 2024 22:19
@davidfischer davidfischer merged commit e9ddcba into main Jun 5, 2024
4 checks passed
@davidfischer davidfischer deleted the davidfischer/vertical-centering-close branch June 5, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants