Skip to content

Use data-ea-placement-bottom to set CSS bottom property #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2024

Conversation

humitos
Copy link
Member

@humitos humitos commented Apr 24, 2024

We require a way to tell EthicalAd client to show the ad above the Read the Docs flyout, so they don't collide.

Peek 2024-04-24 16-15

Closes #188

We require a way to tell EthicalAd client to show the ad above the Read the Docs
flyout, so they don't collide.

Closes #188
Copy link
Contributor

@davidfischer davidfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I added the documentation for it, noted that the value must have a unit, and tested it out. Notably the CSS bottom property doesn't have any effect unless the element is positioned. So this will effect stickybox elements or other custom positioned placement styles but not the default style.

This could have some issues if anybody wants to use CSP but they can use CSS to position it that way if they prefer.

@humitos
Copy link
Member Author

humitos commented May 2, 2024

Thanks for adding the documentation. It seems there is an issue with the tests because it can't install Chrome for some reason. Other than that, I think we are ready to move forward with this. Feel free to merge if you consider.

@davidfischer
Copy link
Contributor

Thanks for adding the documentation. It seems there is an issue with the tests because it can't install Chrome for some reason. Other than that, I think we are ready to move forward with this. Feel free to merge if you consider.

The test issue is fixed by #191 so shouldn't be a problem. I'm going to merge it but probably not deploy it until the offsite so we can discuss rolling it out across RTD.

@davidfischer davidfischer merged commit a3d8bd9 into main May 2, 2024
3 of 4 checks passed
@davidfischer davidfischer deleted the humitos/placement-bottom branch May 2, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ad placement for Read the Docs addons
2 participants