Example to show settings all varialbes at :root explicitly #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use our heuristic to detect the documentation tool/theme and add specific `--readthedocs-*` CSS variables based on that for known tools/themes. Reference: readthedocs/readthedocs.org#11849 (comment)
This moves the inner CSS rules from inside the shadow DOM to the parent DOM. This allows users to still set a `--readthedocs-font-size` and similar variables.
This moves the inner CSS rules from inside the shadow DOM to the parent DOM. This allows users to still set a `--readthedocs-font-size` and similar variables.
Merge branch 'humitos/footer-style' into agj/footer-style
|
Would you mind rebasing this PR since it got some conflicts with the last merges? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #488, this is the first option. Instead of setting each variable at the
point in time we use it (including lots of duplicates) we set all variables at the
:root in the parent DOM. The drops the need for the intermediate
--addons-...variables and gives a point where these variables can be default in one place.
The downside to this generally is that every variable needs to be defined
outside each addon CSS file. We can avoid this and define variables inside the
addon CSS by extracting what we need from the addon CSS.
There are a few ways to do this too though:
variableDefaultsusingcss/CSSStyleSheetfromflyout.js. Thisstill separates variable definition from CSS variable use.
defaults.cssbutwe'd have 8 or so of these files instead of one.