Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor filters for easier maintenance #1503

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Conversation

douglowder
Copy link
Member

📝 Why & how

  • Refactor the code in components/Filters to avoid hardcoding filter params in index.tsx
  • More clearly distinguish between platforms and other filters
  • Clearly distinguish and group filters that require main search path

Screenshot 2025-02-04 at 8 16 50 PM

@douglowder douglowder requested a review from Simek February 5, 2025 11:24
Copy link
Member

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those improvements! 👍

Will follow up with statuses display tweaks, so we no longer list Expo Go along side supported platforms.

@douglowder douglowder merged commit c38f6f0 into main Feb 5, 2025
1 check passed
@douglowder douglowder deleted the @doug/refactor-filters branch February 5, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants