Use webhook.CustomValidator instead of deprecated webhook.Validator. #2803
Conversation
mbobrovskyi
force-pushed
the
cleanup/use-custom-webhook-validator
branch
from
dbef958 to
d70b3e4
Compare
mbobrovskyi
force-pushed
the
cleanup/use-custom-webhook-validator
branch
from
d70b3e4 to
d3ff906
Compare
mbobrovskyi
force-pushed
the
cleanup/use-custom-webhook-validator
branch
3 times, most recently
from
7a8b212 to
45fbd9e
Compare
| @@ -0,0 +1,97 @@ | |||
| package v1 | |||
There was a problem hiding this comment.
@mbobrovskyi could you clarify why this file is moved?
There was a problem hiding this comment.
Kubebuilder, by default, generates webhooks in the internal directory, so I believe this is the better location. Additionally, make generate generates DeepCopy functions for the RayClusterWebhook, even though it is not an API object.
There was a problem hiding this comment.
Got it, would it be feasible to split into two commits ? So that the diffs are easier to read?
In any case posted #2803 (comment).
There was a problem hiding this comment.
Re-opening this, could we make the diff render as moving an existing file instead of a new file?
There was a problem hiding this comment.
You can render the diff like that by looking at the first commit now: 179525c. Unfortunately after the second commit (the move) GH gets confused.
There was a problem hiding this comment.
We can't move the existent file due to RayCluster is an API object.
|
FYI this is the diff of the moved file against the old file: https://www.diffchecker.com/Pt0dqgAt/ |
|
LGTM, I would still consider splitting the PR into dedicated commits to make it easier to read #2803 (comment), but the manual diff is also an option as posted. cc @andrewsykim @kevin85421 over to you |
mbobrovskyi
force-pushed
the
cleanup/use-custom-webhook-validator
branch
from
45fbd9e to
b25d718
Compare
Why are these changes needed?
Currently we are using
webhook.Validatorwhich was deprecated and removed on controller-runtime 1.20. As suggested on controller-runtime https://github.com/kubernetes-sigs/controller-runtime/blob/release-0.17/pkg/webhook/alias.go#L31 we should usewebhook.CustomValidator.Related issue number
Checks