Turn off uploads of nightly conda packages #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They rely on ABI stability of pylibcudf's cython bindings, which doesn't exist.
|
I suspect this would break the nightly This change is the minimal one to stop uploading nightlies that are broken with high probability. |
wence-
commented
May 13, 2025
Comment on lines
+48
to
+56
| # upload-conda: | ||
| # needs: [conda-cpp-build, conda-python-build] | ||
| # secrets: inherit | ||
| # uses: rapidsai/shared-workflows/.github/workflows/[email protected] | ||
| # with: | ||
| # build_type: ${{ inputs.build_type || 'branch' }} | ||
| # branch: ${{ inputs.branch }} | ||
| # date: ${{ inputs.date }} | ||
| # sha: ${{ inputs.sha }} |
There was a problem hiding this comment.
I actually do want to upload the cpp package, but I don't know how to do that. Ideas welcome.
There was a problem hiding this comment.
I think you should be able to add:
skip_upload_pkgs: rapidsmpf
(and maybe librapidsmpf-tests) instead of deleting the step. E.g. used here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They rely on ABI stability of pylibcudf's cython bindings, which doesn't exist.