-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
At least reference the Azure examples #274
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @Tejeev .
I think it would be better to include to quickstart examples links at README.md Provider examples
section. May be makes sense to add an entry by platform supported by quickstart, what do you think??
Something like
Provider examples
-----------------
You can view some tf file examples, [here](examples).
Additional examples can be found at [rancher/quickstart](https://github.com/rancher/quickstart):
* [aws](https://github.com/rancher/quickstart/tree/master/aws)
* [azure](https://github.com/rancher/quickstart/tree/master/azure)
....
On Openstack you can use [terraform-openstack-rke](https://github.com/remche/terraform-openstack-rke) module.
@rawmind0 I like that better, though I know some folks like to reference the examples section if it exists. Should we even leave it in here if we do not use it? |
@Tejeev , I don't think we should leave empty examples as |
@rawmind0 yes, that is what I meant. I think we should just remove the examples section since we do not use it |
I'll check it out and make a pr later |
@Tejeev, i don't fully understand what you mean. Do you mean remove whole example section?? I think that examples are used as reference by users. In fact, there is a PR opened to update them, #272 . |
Oh, I misunderstood and thought you weren't going to use the examples section at all and were saying we shouldn't leave empty sections. IIUC this is what you are saying and if so, I agree and we should close this:
|
Yes, agreed with this. |
No description provided.