[UI] - Adding CIS chart UI tests #13194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izaac
added
the
QA/dev-automation
|
I am moving this to ready as I did a few rounds of testing to see if the I originally thought on only checking creation as that'd be sufficient for the test but checking for |
yonasberhe23
requested changes
Jan 28, 2025
izaac
force-pushed
the
cis-benchmark-tests
branch
2 times, most recently
from
a76221d to
8da5cea
Compare
izaac
force-pushed
the
cis-benchmark-tests
branch
2 times, most recently
from
1f02374 to
784237f
Compare
izaac
commented
Jan 29, 2025
izaac
force-pushed
the
cis-benchmark-tests
branch
from
784237f to
3d9633e
Compare
yonasberhe23
requested changes
Jan 30, 2025
| return new NameNsDescription(this.self()); | ||
| } | ||
|
|
||
| saveCreateForm(): AsyncButtonPo { |
There was a problem hiding this comment.
this can be removed since you already have cruResource()
| return new ResourceListMastheadPo(this.self()); | ||
| } | ||
|
|
||
| createLoggingFlow() { |
There was a problem hiding this comment.
update name and utilize in test on line 66
izaac
force-pushed
the
cis-benchmark-tests
branch
from
3d9633e to
c0dfe0e
Compare
yonasberhe23
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #
rancher/qa-tasks#1547
Occurred changes and/or fixed issues
Adding p0 tests for the UI chart. Includes install and a Scan. Basic functionality.
As well as a YAML view check.
Areas or cases that should be tested
E2E tests. CI
Areas which could experience regressions
CI
Checklist