Skip to content

Some minor fixes and simplifications #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 28, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove specific Gemfile and testing for Ruby 3.1.6
Add it to the tests for all Rubies
rosa committed Jan 28, 2025
commit ade4ec0f0e9aa1c944ae4e6fb74850b89217735b
40 changes: 1 addition & 39 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -24,6 +24,7 @@ jobs:
fail-fast: false
matrix:
ruby-version:
- 3.1.6
- 3.2.0
- 3.2.4
- 3.3.0
@@ -64,42 +65,3 @@ jobs:
bin/rails db:setup
- name: Run tests
run: bin/rails test

tests-ruby-3-1-6:
name: Tests Ruby 3.1.6
runs-on: ubuntu-latest
strategy:
matrix:
database: [ mysql, postgres, sqlite ]
services:
mysql:
image: mysql:8.0.31
env:
MYSQL_ALLOW_EMPTY_PASSWORD: "yes"
ports:
- 33060:3306
options: --health-cmd "mysql -h localhost -e \"select now()\"" --health-interval 1s --health-timeout 5s --health-retries 30
postgres:
image: postgres:15.1
env:
POSTGRES_HOST_AUTH_METHOD: "trust"
ports:
- 55432:5432
env:
TARGET_DB: ${{ matrix.database }}
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Setup Ruby and install specific gems for 3.1.6
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.1.6
- name: Install dependencies with specific Gemfile.lock
run: |
cp Gemfile.lock.ruby_3_1_6 Gemfile.lock
bundle install
- name: Setup test database
run: |
bin/rails db:setup
- name: Run tests
run: bin/rails test
205 changes: 0 additions & 205 deletions Gemfile.lock.ruby_3_1_6

This file was deleted.