Skip to content

Updates bulma.min.css to fix css compile error when using legacy CSS bundlers sass-rails and sassc-rails #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

florian2
Copy link
Contributor

@florian2 florian2 commented Feb 7, 2025

see #237

When using legacy CSS bundlers sass-rails and sassc-rails the file "bulma.min.css" creates a CSS compile error:

"SassC::SyntaxError: Error: Invalid CSS after "...--s),var(--l));": expected "}", was "--00-l:var(--bulma-""

This PR removes the valid, but problematic CSS code. The UI still works as expected, so the removal seems to be ok and the compile error is gone. Big thanks to @barrywoolgar who figured it all out!

@rosa
Copy link
Member

rosa commented Feb 7, 2025

Thank you!

@rosa rosa merged commit 07ef102 into rails:main Feb 7, 2025
3 checks passed
salmonsteak1 added a commit to salmonsteak1/mission_control-jobs that referenced this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants