Fix deprecation warnings and add log entries (#331)

quarkiverse · Feb 9, 2025 · c2cb93c · c2cb93c
1 parent 92fbf14
commit c2cb93c
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 11 deletions.
diff --git a/deployment/src/main/java/io/quarkiverse/unleash/devservices/UnleashDevServiceProcessor.java b/deployment/src/main/java/io/quarkiverse/unleash/devservices/UnleashDevServiceProcessor.java
@@ -21,7 +21,7 @@
 import io.quarkus.deployment.builditem.*;
 import io.quarkus.deployment.console.ConsoleInstalledBuildItem;
 import io.quarkus.deployment.console.StartupLogCompressor;
-import io.quarkus.deployment.dev.devservices.GlobalDevServicesConfig;
+import io.quarkus.deployment.dev.devservices.DevServicesConfig;
 import io.quarkus.deployment.logging.LoggingSetupBuildItem;
 import io.quarkus.devservices.common.ConfigureUtil;
 import io.quarkus.devservices.common.ContainerAddress;
@@ -43,15 +43,15 @@ public class UnleashDevServiceProcessor {
     static volatile UnleashDevServiceCfg cfg;
     static volatile boolean first = true;
 
-    @BuildStep(onlyIfNot = IsNormal.class, onlyIf = { GlobalDevServicesConfig.Enabled.class })
+    @BuildStep(onlyIfNot = IsNormal.class, onlyIf = { DevServicesConfig.Enabled.class })
     public DevServicesResultBuildItem startUnleashContainers(LaunchModeBuildItem launchMode,
             List<DevServicesSharedNetworkBuildItem> devServicesSharedNetworkBuildItem,
             UnleashBuildTimeConfig buildTimeConfig,
             UnleashDbDevServicesProviderBuildItem dbSettings,
             Optional<ConsoleInstalledBuildItem> consoleInstalledBuildItem,
             CuratedApplicationShutdownBuildItem closeBuildItem,
             DockerStatusBuildItem dockerStatusBuildItem,
-            LoggingSetupBuildItem loggingSetupBuildItem, GlobalDevServicesConfig devServicesConfig) {
+            LoggingSetupBuildItem loggingSetupBuildItem, DevServicesConfig devServicesConfig) {
 
         UnleashDevServiceCfg configuration = getConfiguration(buildTimeConfig);
 
@@ -69,7 +69,7 @@ public DevServicesResultBuildItem startUnleashContainers(LaunchModeBuildItem lau
         try {
             devService = startContainer(dockerStatusBuildItem, configuration, dbSettings, launchMode,
                     !devServicesSharedNetworkBuildItem.isEmpty(),
-                    devServicesConfig.timeout);
+                    devServicesConfig.timeout());
 
             if (devService == null) {
                 compressor.closeAndDumpCaptured();

diff --git a/runtime/src/main/java/io/quarkiverse/unleash/runtime/UnleashCreator.java b/runtime/src/main/java/io/quarkiverse/unleash/runtime/UnleashCreator.java
@@ -1,5 +1,7 @@
 package io.quarkiverse.unleash.runtime;
 
+import org.jboss.logging.Logger;
+
 import io.getunleash.DefaultUnleash;
 import io.getunleash.Unleash;
 import io.getunleash.event.UnleashSubscriber;
@@ -12,6 +14,8 @@
 
 public class UnleashCreator {
 
+    private static final Logger LOGGER = Logger.getLogger(UnleashCreator.class);
+
     public static Unleash createUnleash(UnleashRuntimeTimeConfig unleashRuntimeTimeConfig, String name) {
         UnleashConfig.Builder builder = UnleashConfig.builder()
                 .unleashAPI(unleashRuntimeTimeConfig.url())
@@ -47,15 +51,21 @@ public static Unleash createUnleash(UnleashRuntimeTimeConfig unleashRuntimeTimeC
         ArcContainer arcContainer = Arc.container();
         if (arcContainer != null) {
 
-            InstanceHandle<UnleashSubscriber> unleashSubscriber = arcContainer.instance(UnleashSubscriber.class);
-            if (unleashSubscriber.isAvailable()) {
-                builder.subscriber(unleashSubscriber.get());
+            try (InstanceHandle<UnleashSubscriber> unleashSubscriber = arcContainer.instance(UnleashSubscriber.class)) {
+                if (unleashSubscriber.isAvailable()) {
+                    LOGGER.debugf("Found UnleashSubscriber instance: %s",
+                            unleashSubscriber.getBean().getImplementationClass().getName());
+                    builder.subscriber(unleashSubscriber.get());
+                }
             }
 
-            InstanceHandle<ToggleBootstrapProvider> toggleBootstrapProvider = arcContainer
-                    .instance(ToggleBootstrapProvider.class);
-            if (toggleBootstrapProvider.isAvailable()) {
-                builder.toggleBootstrapProvider(toggleBootstrapProvider.get());
+            try (InstanceHandle<ToggleBootstrapProvider> toggleBootstrapProvider = arcContainer
+                    .instance(ToggleBootstrapProvider.class)) {
+                if (toggleBootstrapProvider.isAvailable()) {
+                    LOGGER.debugf("Found ToggleBootstrapProvider instance: %s",
+                            toggleBootstrapProvider.getBean().getImplementationClass().getName());
+                    builder.toggleBootstrapProvider(toggleBootstrapProvider.get());
+                }
             }
         }