only use bottleneck version 1.0 and later #1190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
shoyer
reviewed
Dec 29, 2016
| @@ -17,6 +18,10 @@ | |||
|
|
|||
| try: | |||
| import bottleneck as bn | |||
| if StrictVersion(bn.__version__) < StrictVersion('1.0'): | |||
| warnings.warn('xarray requires bottleneck version of 1.0 or greater.' | |||
There was a problem hiding this comment.
Users find it really annoying to see messages just when importing a package, when they may not even be using the related functionality. Let's only issue the warning when doing rolling aggregations.
There was a problem hiding this comment.
fair enough. The logic gets spread out a bit more but we now only raise the warning when rolling.__init__() is called.
shoyer
approved these changes
Jan 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #808