Add release note for #10277

pydata · dcherian · May 6, 2025 · Apr 30, 2025 · Apr 30, 2025 · Apr 30, 2025
commit db27ee019e386121529b273ab8d8c81b2d4be1b9
diff --git a/doc/whats-new.rst b/doc/whats-new.rst
@@ -97,6 +97,11 @@ Internal Changes
 ~~~~~~~~~~~~~~~~
 - Avoid stacking when grouping by a chunked array. This can be a large performance improvement.
   By `Deepak Cherian <https://github.com/dcherian>`_.
+- The implementation of ``Variable.set_dims`` has changed to use array indexing syntax
+  instead of ``np.broadcast_to`` to perform dimension expansions where
+  all new dimensions have a size of 1. This should improve compatibility with
+  duck arrays that do not support broadcasting (:issue:`9462`, :pull:`10277`).
+  By `Mark Harfouche <https://github.com/hmaarrfk>`_.
 
 .. _whats-new.2025.03.1:
 

diff --git a/xarray/coding/variables.py b/xarray/coding/variables.py
            # otherwise numpy unsigned ints will silently cast to the signed counterpart
            fill_value = fill_value.item()
        # passes if provided fill value fits in encoded on-disk type
        new_fill = encoded_dtype.type(fill_value)
    except OverflowError:
        encoded_kind_str = "signed" if encoded_dtype.kind == "i" else "unsigned"
        warnings.warn(
diff --git a/xarray/core/duck_array_ops.py b/xarray/core/duck_array_ops.py

    if xp == np:
        # numpy currently doesn't have a astype:
        return data.astype(dtype, **kwargs)
    return xp.astype(data, dtype, **kwargs)
	# otherwise numpy unsigned ints will silently cast to the signed counterpart
	fill_value = fill_value.item()
	# passes if provided fill value fits in encoded on-disk type
	new_fill = encoded_dtype.type(fill_value)
Check warning on line 237 in xarray/coding/variables.py GitHub Actions / ubuntu-latest py3.10 min-all-deps NumPy will stop allowing conversion of out-of-bound Python integers to integer arrays. The conversion of 255 to int8 will fail in the future. For the old behavior, usually: np.array(value).astype(dtype)` will give the desired result (the cast overflows). Check warning on line 237 in xarray/coding/variables.py GitHub Actions / ubuntu-latest py3.10 min-all-deps NumPy will stop allowing conversion of out-of-bound Python integers to integer arrays. The conversion of 255 to int8 will fail in the future. For the old behavior, usually: np.array(value).astype(dtype)` will give the desired result (the cast overflows). Check warning on line 237 in xarray/coding/variables.py GitHub Actions / ubuntu-latest py3.10 min-all-deps NumPy will stop allowing conversion of out-of-bound Python integers to integer arrays. The conversion of 255 to int8 will fail in the future. For the old behavior, usually: np.array(value).astype(dtype)` will give the desired result (the cast overflows). Check warning on line 237 in xarray/coding/variables.py GitHub Actions / ubuntu-latest py3.10 min-all-deps NumPy will stop allowing conversion of out-of-bound Python integers to integer arrays. The conversion of 255 to int8 will fail in the future. For the old behavior, usually: np.array(value).astype(dtype)` will give the desired result (the cast overflows). Check warning on line 237 in xarray/coding/variables.py GitHub Actions / ubuntu-latest py3.10 min-all-deps NumPy will stop allowing conversion of out-of-bound Python integers to integer arrays. The conversion of 255 to int8 will fail in the future. For the old behavior, usually: np.array(value).astype(dtype)` will give the desired result (the cast overflows). Check warning on line 237 in xarray/coding/variables.py GitHub Actions / ubuntu-latest py3.10 min-all-deps NumPy will stop allowing conversion of out-of-bound Python integers to integer arrays. The conversion of 255 to int8 will fail in the future. For the old behavior, usually: np.array(value).astype(dtype)` will give the desired result (the cast overflows). Check warning on line 237 in xarray/coding/variables.py GitHub Actions / ubuntu-latest py3.10 min-all-deps NumPy will stop allowing conversion of out-of-bound Python integers to integer arrays. The conversion of 255 to int8 will fail in the future. For the old behavior, usually: np.array(value).astype(dtype)` will give the desired result (the cast overflows). Check warning on line 237 in xarray/coding/variables.py GitHub Actions / ubuntu-latest py3.10 min-all-deps NumPy will stop allowing conversion of out-of-bound Python integers to integer arrays. The conversion of 255 to int8 will fail in the future. For the old behavior, usually: np.array(value).astype(dtype)` will give the desired result (the cast overflows). Check warning on line 237 in xarray/coding/variables.py GitHub Actions / ubuntu-latest py3.10 min-all-deps NumPy will stop allowing conversion of out-of-bound Python integers to integer arrays. The conversion of 255 to int8 will fail in the future. For the old behavior, usually: np.array(value).astype(dtype)` will give the desired result (the cast overflows). Check warning on line 237 in xarray/coding/variables.py GitHub Actions / ubuntu-latest py3.10 min-all-deps NumPy will stop allowing conversion of out-of-bound Python integers to integer arrays. The conversion of 255 to int8 will fail in the future. For the old behavior, usually: np.array(value).astype(dtype)` will give the desired result (the cast overflows).
	except OverflowError:
	encoded_kind_str = "signed" if encoded_dtype.kind == "i" else "unsigned"
	warnings.warn(

	if xp == np:
	# numpy currently doesn't have a astype:
	return data.astype(dtype, **kwargs)
Check warning on line 237 in xarray/core/duck_array_ops.py GitHub Actions / macos-latest py3.10 `invalid value encountered in cast` Check warning on line 237 in xarray/core/duck_array_ops.py GitHub Actions / macos-latest py3.10 `invalid value encountered in cast` Check warning on line 237 in xarray/core/duck_array_ops.py GitHub Actions / ubuntu-latest py3.10 `invalid value encountered in cast` Check warning on line 237 in xarray/core/duck_array_ops.py GitHub Actions / ubuntu-latest py3.10 `invalid value encountered in cast` Check warning on line 237 in xarray/core/duck_array_ops.py GitHub Actions / windows-latest py3.10 `invalid value encountered in cast` Check warning on line 237 in xarray/core/duck_array_ops.py GitHub Actions / windows-latest py3.10 `invalid value encountered in cast`
	return xp.astype(data, dtype, **kwargs)