Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for versionremoved directive #2087

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

stevepiercy
Copy link
Contributor

Note that I added a snippet in the Kitchen Sink to preview the change. I have an open PR in sphinx-themes/sphinx-themes.org#163 to add it upstream. I can remove this snippet, if you prefer, or you can clobber it the next time you run a sync.

Screenshot 2024-12-20 at 3 38 59 AM

Screenshot 2024-12-20 at 3 40 17 AM

Note that I added a snippet in the Kitchen Sink to preview the change. I have an open PR in sphinx-themes/sphinx-themes.org#163 to add it upstream. I can remove this snippet, if you prefer, or you can clobber it the next time you run a sync.

I'll also attach a screenshot.

- Closes pydata#2086
@stevepiercy
Copy link
Contributor Author

stevepiercy commented Dec 20, 2024

The failing CI check appears to be due to the requirement of Sphinx 6.1 on Python 3.9:
https://github.com/pydata/pydata-sphinx-theme/actions/runs/12430785015/job/34706895092#step:4:397

This feature appeared in Sphinx 7.3.

I'm not sure what to do for this. Please let me know. Thank you!

Copy link

github-actions bot commented Jan 21, 2025

Coverage report

This PR does not seem to contain any modification to coverable code.

@drammock
Copy link
Collaborator

@stevepiercy I've fixed the CI error by adding the warnings to our "expected but intermittent warnings" list. AFAIC this is ready to go, but needs #2083 (and then another merge-main) for the RTD build to succeed again.

@drammock drammock merged commit 6345c7d into pydata:main Jan 24, 2025
25 checks passed
@drammock
Copy link
Collaborator

drammock commented Jan 24, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add style for versionremoved directive
2 participants