This repository was archived by the owner on Feb 12, 2025. It is now read-only.
Update miTLS after removal of legacy modules in HACL* #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this also removes the ability to compile & link against bcrypt. This can be easily restored should the need arise, but does not seem critical for the moment. |
|
@tahina-pro and @ad-l discussed this in person. The plan is to merge this, then:
|
Done.
I opened #255 to this end. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the companion PR to hacl-star/hacl-star#584
Specifically, legacy modules EverCrypt, EverCrypt.Specs, EverCrypt.OpenSSL and EverCrypt.Hacl all move to miTLS. The corresponding C implementations also move to miTLS.
I did not restore quic_provider since it is now superseded by everquic-crypto. I intend to tag the corresponding revision in HACL* and miTLS so that we can easily revive quic_provider should the (unlikely) need arise.