Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ToggleSwitch): request header correction #3291

Merged
merged 5 commits into from
Jan 27, 2025

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Jan 24, 2025

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Adds X-Requested-with header to ToggleSwitch.

Integration

N/A

List the issues that this change affects.

Closes https://github.com/github/primer/issues/4704

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@francinelucca francinelucca requested a review from a team as a code owner January 24, 2025 20:42
Copy link

changeset-bot bot commented Jan 24, 2025

🦋 Changeset detected

Latest commit: 6a91bd1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some discussion/research, two things have become apparent:

  1. We're already trying to set the right header and I didn't notice 🤦
  2. The header we're setting is wrong. It should be X-Requested-With 🤦 🤦

Let's add the X- prefixed header and leave the old one in there too in case someone is relying on it.

@francinelucca francinelucca changed the title fix(ToggleSwitch): change requested-with header to fetch fix(ToggleSwitch): request header correction Jan 25, 2025
@jonrohan jonrohan dismissed camertron’s stale review January 27, 2025 22:24

Changes addressed

@jonrohan jonrohan merged commit aeaeb96 into main Jan 27, 2025
34 checks passed
@jonrohan jonrohan deleted the fix/toggle-switch-request-header branch January 27, 2025 22:24
@primer primer bot mentioned this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants