-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ToggleSwitch): request header correction #3291
Conversation
🦋 Changeset detectedLatest commit: 6a91bd1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some discussion/research, two things have become apparent:
- We're already trying to set the right header and I didn't notice 🤦
- The header we're setting is wrong. It should be
X-Requested-With
🤦 🤦
Let's add the X-
prefixed header and leave the old one in there too in case someone is relying on it.
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
Adds
X-Requested-with
header toToggleSwitch
.Integration
N/A
List the issues that this change affects.
Closes https://github.com/github/primer/issues/4704
Risk Assessment
What approach did you choose and why?
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.