-
Notifications
You must be signed in to change notification settings - Fork 290
feat: allow searching for specific package versions using matchspec #3565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow searching for specific package versions using matchspec #3565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! This looks great! I left one small comment!
👀 any progress? I can work on this is the author allow it |
@trim21 from our side you would be welcome to continue this work! If @simonjung1603 doesn't react I would recommend to fork his work and continue from there. |
Hey, I am fine with either. I'd happily continue, frankly I wasn't sure how you wanted me to proceed as I didn't get a reply on my comment about wildcard matchspec and the error message. Sorry for not poking you to follow up but I was otherwise occupied. @trim21 if you have enough changes planned and want to take over, you have my permission. Just let me know. If all this needs to be merged is a rewording of the diagnostic though then I'd propose I finish it. |
So looks like this is a communication things 🤔 |
I'm so sorry, this is totally my fault, I lost track of this PR. I took the responsibility of testing and adjusting the PR so that it would be merge ready in my opinion. @simonjung1603 Thanks for the work! |
solves #3173
I allowed specifying a MatchSpec for the exact search so that for example
pixi search "rattler-build<=0.35.4"
pixi search "rattler-build[build=h3ab7716_0]"
are valid search calls and yield the respective package versions.
I added the examples from the issue to the search_extender docs.
I added a test case in
search_tests.rs
for this feature.