Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(i18n): add Korean translation tutorial/index.md #1039

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

n0hack
Copy link
Contributor

@n0hack n0hack commented Dec 19, 2023

Hello, I have a personal suggestion along with the first translation.

It would be good to apply i18n to the buttons in the tutorial text as well.
For example, the "Previous" button can be translated into Korean as "이전".

<div class={style.buttonContainer}>
	{page.meta.prev && (
		<a class={style.prevButton} href={page.meta.prev}>
			Previous // {config.i18n.previous[lang] ?? "Previous"}
		</a>
	)}
	{tutorial.state['repl-final'] && (
		<button
			class={style.helpButton}
			onClick={tutorial.help}
			disabled={!showCode}
			title="Get help with this example"
		>
			Help
		</button>
	)}
	{page.meta.next && (
		<a class={style.nextButton} href={page.meta.next}>
			{page.meta.nextText || 'Next'}
		</a>
	)}
</div>

@rschristian
Copy link
Member

It would be good to apply i18n to the buttons in the tutorial text as well.
For example, the "Previous" button can be translated into Korean as "이전".

Indeed, sounds like a good idea. Feel free to implement or create an issue for tracking that.

Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rschristian rschristian merged commit 245798d into preactjs:master Dec 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants