SDL3: Enable raw keyboard on Windows #6507
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Susko3
changed the title
|
Keep in mind that the hint can be toggled while the game is running. So if some issue is a deal-breaker, we can just toggle the hint off as needed. Example: if someone has a gaming keyboard that can disable the windows key in hardware, they don't need our software solution, so they would only benefit from raw keyboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
With #6506, this will handle keyboard events on a dedicated thread to bypass the usual SDL event flow, leading to lower latency and immunity from main thread lag (we sometimes see
SDL_PumpEvents()take a long time). Mouse input is already handled on this dedicated thread when relative mouse mode is enabled.This PR is blocked as it breaks disabling the windows key during gameplay in osu!. Raw keyboard input will bypass the hook that is supposed to disable the windows key. I found some plausible workaround for this, but they are very hacky and might increase latency.
Enabling raw keyboard may lead to timing issues wrt
TextBoxtext input & related handling. This PR needs to be tested to check for IME regressions.