refactor: Connect Python assert_series_equal() to Rust back-end
#23141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kevin-Patyk
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
github-actions
bot
added
internal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #23141 +/- ##
==========================================
- Coverage 80.85% 80.61% -0.25%
==========================================
Files 1615 1636 +21
Lines 217417 219813 +2396
Branches 2809 2806 -3
==========================================
+ Hits 175789 177193 +1404
- Misses 40964 41955 +991
- Partials 664 665 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coastalwhite
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@coastalwhite
This is the first PR to connect the the new Rust back-end testing functionality to Python. This PR only covers
assert_series_equal()since I didn't want the PR to be too large and it was my first time doing something like this. The next PR will coverassert_dataframe_equal().I didn't want to meddle too much in the existing Python tests since they are robust and well-written, so I only made 2 very minor changes to the tests because of how they were structured. Otherwise, all tests pass without any interference.
Lastly, the now deprecated Python code has still not been removed from the related files. This is because the Python
assert_dataframe_equal()functionality in Python still relies on that code, so if I delete it without first connecting it to the Rust back-end, it causes a lot of issues. The code will be removed during the PR for connectingassert_dataframe_equal().