Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.7.2 #37

Merged
merged 13 commits into from
Jul 19, 2021
Merged

Release 3.7.2 #37

merged 13 commits into from
Jul 19, 2021

Conversation

pocketken
Copy link
Owner

  • adds fix and matching tests for h3NeighborRotations (H3HierarchyExtensions.GetDirectNeighbour) from upstream release 3.7.2
  • adds additional missing upstream tests for H3Index.IsValid
  • adds equivalent of upstream PR 496 IsValid optimizations -- should probably have done a before/after benchmark, but meh. It smells faster...?
  • bugfix: prevent H3IndexJsonConverter from treating obviously non-H3 string values as index values
  • change Mode.Hexagon to Mode.Cell to align with upstream; update function documentation and whatnot to refer to cells instead of hexagons to be consistent there as well.

Should probably look at what else we want to align with upstream naming-wise (e.g., grid disk instead of hex ring) in future PRs.

@pocketken pocketken linked an issue Jul 19, 2021 that may be closed by this pull request
@pocketken pocketken merged commit 0264123 into main Jul 19, 2021
@pocketken pocketken deleted the dev/km/gh-36-release-3.7.2 branch July 19, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update for 3.7.2
1 participant