Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify on reload #512

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Notify on reload #512

merged 1 commit into from
Jun 16, 2021

Conversation

fregante
Copy link
Contributor

Closes #506

twschiller
twschiller approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@twschiller twschiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using iterm2 + zsh I don't getting the icons, but am getting the notifications. @fregante are you getting the status icons too?

@twschiller twschiller merged commit 4832bae into main Jun 16, 2021
@twschiller twschiller deleted the dev/notify-on-reload branch June 16, 2021 13:01
@fregante
Copy link
Contributor Author

No custom icon: RoccoC/webpack-build-notifier#59 (comment)

Might be because:

-appIcon PATH

Specify an image PATH to display instead of the application icon.

WARNING: This option is subject to change, since it relies on a private method.

From https://github.com/julienXX/terminal-notifier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twschiller twschiller twschiller approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notify on reload and errors in Webpack watch mode
2 participants
@fregante @twschiller