Skip to content

Update local option in build script to compile FTL directly #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

PromoFaux
Copy link
Member

What does this PR aim to accomplish?:

Have been meaning to do this for a while, finally found the motivation to do so.

I like that docker is smart enough to know that it can skip certain stages if the final image does not use anything from them


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

@PromoFaux PromoFaux requested review from a team and Copilot April 5, 2025 11:19
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • build.sh: Language not supported
  • src/Dockerfile: Language not supported

@PromoFaux PromoFaux force-pushed the build-FTL branch 2 times, most recently from 3e95ccd to ac7c190 Compare April 5, 2025 11:21
…her than relying on the binary having already been build externally

Signed-off-by: Adam Warner <[email protected]>
@DL6ER
Copy link
Member

DL6ER commented Apr 5, 2025

What is the advantage compared to downloading the ready-made binaries?

Except, maybe,

  • can do this even when the binaries have nit (yet) finished compiling,
  • works also on unsupported platforms (well, if docker works there, at least)

@PromoFaux
Copy link
Member Author

PromoFaux commented Apr 5, 2025

There you go, you've listed the advantages.

I can't imagine that anyone other than me ever uses it - and just sometimes I want to be able to test things before the CI has got to it.

Edit: though you make a good point... And it has me now thinking "What if I want to use a branch I am working on locally?... back to the drawing board

@PromoFaux PromoFaux marked this pull request as draft April 5, 2025 13:01
@yubiuser
Copy link
Member

yubiuser commented Apr 5, 2025

I'm not sure if this is really needed. The CI builds fast except of RISCV and will push the binaries after each architecture finishes. So for most it should be available within minutes.

If you want to include a local FTL branch which you need to build first - well, we have the FTL devcontainer. Moving the binary from the FTL repo to the docker repo and include it with the -l flag seems manageable.

@PromoFaux
Copy link
Member Author

By the same token ./build.sh is not really needed - it just makes it easier. ;)

But comments understood and agreed with on the main - I realise that building locally in one fell swoop is more useful if they are local modifications not available from github.

Moving the binary from the FTL repo to the docker repo and include it with the -l flag seems manageable.

This step annoys me more often than it should, which was what the main goal was here 😏

I've got some ideas that I may or may not look at in future

@PromoFaux PromoFaux closed this Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants