fix: alpine bash issue #1786
Closed
fix: alpine bash issue #1786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. I'm currently unable to test this (vacation 🎉) but this is something I had in mind. If this works as intended, I would also revert pi-hole/pi-hole#6030 as this is more a workout then the proper fix and has it's own regressions. |
mwoolweaver
added a commit
to mwoolweaver/pi-hole
that referenced
this pull request
Mar 14, 2025
in preparation for pi-hole/docker-pi-hole/pull/1786 Signed-off-by: Michael Woolweaver <[email protected]>
1 task
LizenzFass78851
force-pushed
the
fix/alpine-issue
branch
2 times, most recently
from
b1818ad to
8ce4f5a
Compare
Signed-off-by: LizenzFass78851 <[email protected]>
LizenzFass78851
force-pushed
the
fix/alpine-issue
branch
from
8ce4f5a to
85c42bb
Compare
Signed-off-by: LizenzFass78851 <[email protected]>
LizenzFass78851
force-pushed
the
fix/alpine-issue
branch
from
3f2c325 to
e84b636
Compare
1 task
- chmod of fix alpine issue is not needed - change directory and name of non-interactive sh file - change name of env Signed-off-by: LizenzFass78851 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This creates a symlink for the
testand[commands to make them executable viabusyboxand notcoreutils. It writes commands to disable thebashinternaltestand[commands both in thebashrc(for interactive sessions) and in a separate sh file that is used as a script for non-interactive sessions (specified via an env). This way, at least the execution ofbashinternal commands liketestand[can be prevented and thesebusyboxcommands can be used instead.Motivation and Context
This (hopefully) fixes: #1767
How Has This Been Tested?
I tested this on an Ubuntu 20.04 VM with an outdated containerd.io package to be able to reproduce the bash alpine issue and test its fix. More details here.
Types of changes
Checklist: