-
-
Notifications
You must be signed in to change notification settings - Fork 128
Allow specification of the exact API URL via new option --api #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Allow specification of the exact API URL via new option --api #463
Conversation
2c69b49
to
e403b93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking we probably should add a new option/flag like --api
where users can specify the api URL. I'm not sure mixing the URL with the server domain/IP is desirable. And we should make it clear that this is an advanced feature most users probably never need.
This is a good Idea and will also avoid potential issues with the functionality I introduced in #450, since it assumes SERVER is an IP. |
Signed-off-by: darkexplosiveqwx <[email protected]>
Signed-off-by: darkexplosiveqwx <[email protected]>
Signed-off-by: darkexplosiveqwx <[email protected]>
Signed-off-by: darkexplosiveqwx <[email protected]>
1769658
to
13d5dea
Compare
Signed-off-by: darkexplosiveqwx <[email protected]>
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
Allows SERVER to be the full API path, eliminating the need for the extra DNS lookup.
This also allows multiple APIs on the same server (like
https://pi.hole/pihole1/api
andhttps://pi.hole/pihole2/api
).PADD will still work even if the DNS record doesn't work.
This fixes my original problem I specified on discourse
How does this PR accomplish the above?:
Check if
SERVER
starts withhttps://
orhttp://
and setschaos_api_list
toSERVER
.Link documentation PRs if any are needed to support this PR:
By submitting this pull request, I confirm the following:
git rebase
)