クレジットカード決済を3Dセキュア2.0に対応する #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uchinokot
force-pushed
the
support-3ds2.0
branch
from
30e13a9 to
b908cfb
Compare
ken3ypa
reviewed
Sep 16, 2022
Comment on lines
+25
to
+35
| RISK_BASE_AUTH_PARAMS_KEYS = %i[ | ||
| tds_flag billAddrCity billAddrCountry billAddrLine1 billAddrLine2 billAddrLine3 | ||
| billAddrPostCode billAddrState shipAddrCity shipAddrCountry shipAddrLine1 shipAddrLine2 | ||
| shipAddrLine3 shipAddrPostCode shipAddrState chAccAgeInd chAccChange | ||
| chAccChangeIndchAccDate chAccPwdChange chAccPwChangeInd nbPurchaseAccount paymentAccAge | ||
| paymentAccInd provisionAttemptsDay shipAddressUsage shipAddressUsageInd shipNameIndicator | ||
| suspiciousAccActivity txnActivityDay txnActivityYear threeDSReqAuthData threeDSReqAuthMethod | ||
| threeDSReqAuthTimestamp addrMatch cardholderName homePhone mobilePhone | ||
| workPhone challengeInd deliveryEmailAddress deliveryTimeframe giftCardAmount | ||
| giftCardCount preOrderDate preOrderPurchaseInd reorderItemsInd shipIndicator | ||
| ].freeze |
ken3ypa
reviewed
Sep 16, 2022
| giftCardCount preOrderDate preOrderPurchaseInd reorderItemsInd shipIndicator | ||
| ].freeze | ||
|
|
||
| THREE_D_SECURE_2_INDICATORS = [21, 22].freeze |
ken3ypa
reviewed
Sep 16, 2022
| FAILURE = '0' | ||
| SUCCESS = '1' | ||
| THREE_D_SECURE_1 = '5' | ||
| THREE_D_SECURE_2 = '6' |
ken3ypa
reviewed
Sep 16, 2022
Comment on lines
+178
to
+180
| tds_flag: 21 # 21 or 22 | ||
| # optional: | ||
| # add params for risk-based certification(billAddrCity etc...) |
ken3ypa
approved these changes
Sep 16, 2022
akira888
reviewed
Sep 16, 2022
| params.merge!(detail.slice(*RISK_BASE_AUTH_PARAMS_KEYS).compact) | ||
| end | ||
|
|
||
| commit(PATHS[:registered_purchase], params) |
Closed
uchinokot
force-pushed
the
support-3ds2.0
branch
from
2a56f62 to
a95302b
Compare
イプシロンのAPI改修が終わり正常にレスポンスが返ってくるようになったので
akira888
approved these changes
Sep 21, 2022
| @@ -5,7 +5,7 @@ http_interactions: | |||
| uri: https://secure.epsilon.jp/cgi-bin/order/direct_card_payment.cgi | |||
| body: | |||
| encoding: UTF-8 | |||
| string: contract_code=[CONTRACT_CODE]&user_id=U1663229130&user_name=YAMADA+Taro&user_mail_add=yamada-taro%40example.com&item_code=ITEM001&item_name=Greate+Product&order_number=O30189731&st_code=10000-0000-0000&mission_code=1&item_price=1000&process_code=1&card_st_code=&pay_time=&tds_check_code=1&user_agent=ActiveMerchant%3A%3AEpsilon-0.13.0&token=03d4a2ce2f747c9223a4ead24888d0293ad26c06273e296f9faa0675f99a1ff7&security_code=&security_check=1&tds_flag=21 | |||
| string: contract_code=[CONTRACT_CODE]&user_id=124014051&user_name=YAMADA+TARO&user_mail_add=yamada-taro%40example.com&item_code=ITEM001&item_name=Greate+Product&order_number=O1663728963&st_code=10000-0000-0000&mission_code=1&item_price=1000&process_code=2&card_st_code=&pay_time=&xml=1&tds_flag=21 | |||
There was a problem hiding this comment.
process_code=2で、test_helperの設定した情報でカセットが取り直せていることを確認しました
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
目的
3Dセキュア1.0は2022年10月13日に閉塞されるので、3Dセキュア2.0に対応できるようにします。
変更内容詳細や仕様書はイプシロンからのお知らせにあります。
対応内容は以下です。
purchaseとregistered_purchaseに対応registered_recurring）は3Dセキュア対応のクレジットカードが利用できないので対応していないregistered_purchaseのテストも登録済み課金 + 3Dセキュア2.0用のVCRカセットを使用registered_purchaseのテストは一時的に他のVCRカセットを使って追加