GMO後払い version 1 を使うようにする #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 18, 2020 15:15
エラー発生時に error_detail などのキーが含まれなくなっていたため
ku00
reviewed
Mar 19, 2020
| end | ||
|
|
||
| decoded_string | ||
| CGI.unescape(string).encode(Encoding::UTF_8, Encoding::CP932) |
There was a problem hiding this comment.
ちゃんと戻っている 👀
cadf7d2#diff-2d95049f89d68d5ec1ac63e2ea43621f
odaillyjp
reviewed
Mar 19, 2020
| @@ -1,6 +1,11 @@ | |||
| module ActiveMerchant #:nodoc: | |||
| module Billing #:nodoc: | |||
| class EpsilonGmoAfterGateway < EpsilonBaseGateway | |||
|
|
|||
| RESPONSE_KEYS = DEFAULT_RESPONSE_KEYS + [ | |||
There was a problem hiding this comment.
エラー発生時に error_detail などのキーが含まれなくなっていたため
👍
itakurara
approved these changes
Mar 19, 2020
| @@ -30,7 +35,7 @@ def purchase(amount, detail = {}) | |||
| params[:memo2] = detail[:memo2] if detail.has_key?(:memo2) | |||
| params[:user_tel] = detail[:user_tel] if detail.has_key?(:user_tel) | |||
|
|
|||
| commit('receive_order3.cgi', params, [:redirect]) | |||
| commit('receive_order3.cgi', params, RESPONSE_KEYS) | |||
|
レビューありがとうございます。 バージョンアップ用のPRを #107 を参考にして別途出しますー |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
参考：
イプシロン決済システム仕様書 Ver.1.0.41 p44, 45