GMO後払い決済に対応する #106
Merged
GMO後払い決済に対応する #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 11, 2020 11:53
ruby-head(ruby 2.8.0dev)でFile does not exist:rexml/documentというエラーになる。 2.8.0devでREXMLが添付ライブラリから外されたという情報があり、その影響とみられる。 ruby-headのバージョンは安定板ではないし、テストをするのをやめる。
itakurara
force-pushed
the
gmo-later-payment
branch
from
1f9e26f to
e4980ea
Compare
ku00
reviewed
Mar 13, 2020
| item_code: detail[:item_code], | ||
| item_name: detail[:item_name], | ||
| order_number: detail[:order_number], | ||
| st_code: '00000-0000-00000-00000-00100-00000-00000', |
There was a problem hiding this comment.
決済区分は以下が正しいかと思いました
Suggested change
| st_code: '00000-0000-00000-00000-00100-00000-00000', | |
| st_code: '00000-0000-00000-00010-00000-00000-00000', |
書式:NNNNN-NNNN-NNNNN-NNNNN-NNNNN-NNNNN-NNNNN
(以下表の対比12345-6789-ABCDE-FGHIJ-KLMNO-PQRST-UVWXY)
「GMO後払い決済」は対応表（p.46）を見る限り I だったので
yono
reviewed
Mar 13, 2020
| item_code: detail[:item_code], | ||
| item_name: detail[:item_name], | ||
| order_number: detail[:order_number], | ||
| st_code: '00000-0000-00000-00000-00100-00000-00000', |
There was a problem hiding this comment.
銀行振込(バーチャル口座) の設定になっているようです 🙏
仕様書 p.46 より
yono
reviewed
Mar 13, 2020
| uri: https://beta.epsilon.jp/cgi-bin/order/receive_order3.cgi | ||
| body: | ||
| encoding: UTF-8 | ||
| string: contract_code=[CONTRACT_CODE]&user_id=&user_name=YAMADA+Taro&user_mail_add=yamada-taro%40example.com&item_code=ITEM001&item_name=Greate+Product&order_number=O17949889&st_code=00000-0000-00000-00000-00100-00000-00000&mission_code=1&item_price=10000&process_code=1&xml=1&delivery_code=99&consignee_postal=1500002&consignee_name=%E3%82%A4%E3%83%97%E3%82%B7%E3%83%AD%E3%83%B3%E3%82%BF%E3%83%AD%E3%82%A6&consignee_address=%E6%9D%B1%E4%BA%AC%E9%83%BD%E6%B8%8B%E8%B0%B7%E5%8C%BA%EF%BC%91%E2%88%92%EF%BC%91%E2%88%92%EF%BC%91&consignee_tel=0312345678&orderer_postal=1500002&orderer_name=YAMADA+Taro&orderer_address=%E6%9D%B1%E4%BA%AC%E9%83%BD%E6%B8%8B%E8%B0%B7%E5%8C%BA1-1-1&orderer_tel=0312345678&version=2&memo1=memo1&memo2=memo2 |
There was a problem hiding this comment.
VCRのカセットの決済区分も 銀行振込(バーチャル口座) になっているので、こちらもご確認ください 🙏
|
レビューありがとうございます！修正したので再度お願いします 🙏 ご指摘いただいた箇所以外で、英語の表記名について見直して、そちらも修正しております。 |
ku00
reviewed
Mar 13, 2020
| @@ -302,6 +302,45 @@ else | |||
| end | |||
| ``` | |||
|
|
|||
| ### GMO Payment After Delivery | |||
|
レビューありがとうございました！ マージreadyなのでマージしてしまおうかと思ったのですが、 |
|
@itakurara |
|
ありがとうございます〜！ではではこちらはマージしてしまいます 🚀 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
イプシロン決済システム仕様書 Ver.1.0.41 p44, 45