Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use of the obsolete method #104

Merged
merged 2 commits into from
Oct 4, 2019
Merged

Fix use of the obsolete method #104

merged 2 commits into from
Oct 4, 2019

Conversation

kenchan
Copy link
Contributor

@kenchan kenchan commented Oct 2, 2019

URI.decode is obsolete method. In this case, it is appropriate to use CGI.unescape.

https://docs.ruby-lang.org/en/latest/class/URI.html#S_DECODE

@kenchan
Copy link
Contributor Author

kenchan commented Oct 3, 2019

Fix CI #105

piyoppi
piyoppi approved these changes Oct 4, 2019
View reviewed changes
Copy link

@piyoppi piyoppi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~ 🐤

@kenchan
Copy link
Contributor Author

kenchan commented Oct 4, 2019

Thanks for your review!

@kenchan kenchan merged commit a55cd6a into master Oct 4, 2019
@kenchan kenchan deleted the fix-obsolete-method-warning branch October 4, 2019 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyoppi piyoppi piyoppi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenchan @piyoppi