Add EURC and XLM assets from Pendulum #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Releases: @galacticcouncil/[email protected]
gianfra-t
changed the title
Releases: @galacticcouncil/[email protected]
Releases: @galacticcouncil/[email protected]
Releases: @galacticcouncil/[email protected]
Releases: @galacticcouncil/[email protected]
ebma
reviewed
Apr 28, 2025
| new AssetRoute({ | ||
| source: { | ||
| asset: eurc, | ||
| balance: BalanceBuilder().substrate().system().account(), |
There was a problem hiding this comment.
Are you sure that this is correct? Only the native asset balance can be accessed in the system::account() query so I guess this is wrong?
There was a problem hiding this comment.
You may be right, I didn't think about this and it wasn't important to create the transaction itself according to the tests, but it may be for the UI.
There was a problem hiding this comment.
Haha yeah I guess it's important, otherwise the balance won't show correctly.
chore: add license badge
Releases: @galacticcouncil/[email protected] @galacticcouncil/[email protected]
Releases: @galacticcouncil/[email protected]
Releases: @galacticcouncil/[email protected]
ebma
approved these changes
May 9, 2025
|
Thanks! Here is the PR to upstream. I think last step is to test once they provide the preview. And add the icons, but for that we need to confirm the id's are okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: Tasks/#434