Skip to content

chore: adds filters #12622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore: adds filters #12622

wants to merge 5 commits into from

Conversation

kendelljoseph
Copy link
Contributor

No description provided.

@kendelljoseph kendelljoseph requested a review from denolfe May 30, 2025 16:18
@denolfe
Copy link
Member

denolfe commented May 30, 2025 •
edited
Loading

A few questions/notes:

  • Can we validate that this function call is actually doing anything? Feels like we should have a test. The library doesn't appear to have any types, which makes me a little more uneasy.
  • From reading, looks like this lib throws an error in the scenario where the URL is blocked. We should catch and rethrow an APIError, so it is handled nicely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denolfe denolfe Awaiting requested review from denolfe

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
created-by: Payload team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kendelljoseph @denolfe