fix: proper globals max versions clean up #12611
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r1tsuu
changed the title
deleteGlobalVersions to db adaptersdeleteGlobalVersions to db adapters, proper globals max versions clean up
DanRibbens
reviewed
May 30, 2025
| where: deleteQuery, | ||
| }) | ||
| if (globalConfig) { | ||
| await payload.db.deleteGlobalVersions({ slug, req, where: deleteQuery }) |
There was a problem hiding this comment.
I'm concerned this could be considered a breaking change. IF another db adapter existed in the community we've added a new function that won't exist. This is a grey area.
If we sent the global slug to db.deleteVersions would our current adapters have just worked?
r1tsuu
force-pushed
the
fix/delete-versions-global
branch
from
4e8b04b to
3927367
Compare
r1tsuu
changed the title
deleteGlobalVersions to db adapters, proper globals max versions clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11879