chore: migrate to TypeScript strict in Payload package - Part 2/N #12574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GermanJablo
commented
May 27, 2025
| @@ -27,7 +24,7 @@ export type BaseVersionField = { | |||
|
|
|||
| export type VersionField = { | |||
| field?: BaseVersionField | |||
| fieldByLocale?: Record<TypedLocale, BaseVersionField> | |||
| fieldByLocale?: Record<string, BaseVersionField> | |||
There was a problem hiding this comment.
TypedLocale can be either string or null
GermanJablo
commented
May 27, 2025
Comment on lines
+7
to
+9
| // @ts-expect-error - vestiges of when tsconfig was not strict. Feel free to improve | ||
| const secret = this.secret | ||
| const cipher = crypto.createCipheriv(algorithm, secret, iv) |
There was a problem hiding this comment.
Since I think it might be useful to someone in the future, I'm sharing the reasoning here as a safety tip: extracting the conflicting variable to a new line is intentional. I tend to do this because if another error appears on the line below, @ts-expect-error would silence them all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: An intentional effort is being made during migration to not modify runtime behavior except in very rare exceptions. This implies that there will be several assertions, non-null assertions, and
@ts-expect-error. This philosophy applies only to migrating old code to TypeScript strict, not to writing new code. For a more detailed justification for this reasoning, read this comment.