Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: PMD sarif report preview unavailable. #4571

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −0
Open

Fix: PMD sarif report preview unavailable. #4571

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f24f45
Fix: PMD sarif report preview unavailable.
xezzon Jan 22, 2025
55b7e8c
Add entry to the CHANGELOG.
xezzon Jan 23, 2025
0070326
Replace the content without leaving the `/` at the beginning of the p…
xezzon Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ Note: Can be used with `oxsecurity/megalinter@beta` in your GitHub Action mega-l

- Fixes
- [swiftlint](https://github.com/realm/SwiftLint) Fix swiftlint error where linter is unable to find lintable files. Fixes [#440](https://github.com/oxsecurity/megalinter/issues/440).
- [SARIF_REPORTER](https://megalinter.io/latest/reporters/SarifReporter/) Fix PMD SARIF report preview unavailable. Fixes [#4522](https://github.com/oxsecurity/megalinter/issues/4522).

- Reporters

Expand Down
1 change: 1 addition & 0 deletions megalinter/reporters/SarifReporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ def produce_report(self):
os.remove(linter.sarif_output_file)
result_json = json.dumps(sarif_obj, sort_keys=True, indent=4)
# Remove workspace prefix from file names
result_json = result_json.replace("file:///github/workspace", "")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't you need replaceAll ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xezzon ? :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does replaceAll mean? Putting file:///github/workspace/d' into LIST_OF_REPLACEMENTS`?

result_json = normalize_log_string(result_json)
# Write output file
sarif_file_name = f"{self.report_folder}{os.path.sep}" + config.get(
Expand Down
Loading