Skip to content

Product page improvements #6789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

PrimaelQuemerais
Copy link
Member

What

This PR addresses a handful of bugs and introduces some improvements to the product page following the integration of tabs.

Do not merge yet, this contains some sort in progress and I intend to add more fixes from the epic.

Screenshot

Screenshot 2025-07-21 at 8 49 09 AM

Part of

#6680

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 1.04167% with 95 lines in your changes missing coverage. Please review.

Project coverage is 5.36%. Comparing base (4d9c7fc) to head (0996cb3).
Report is 964 commits behind head on develop.

Files with missing lines Patch % Lines
...b/pages/product/product_page/new_product_page.dart 0.00% 36 Missing ⚠️
...duct/product_page/product_page_tab_controller.dart 0.00% 28 Missing ⚠️
...product/product_page/header/product_page_tabs.dart 3.57% 27 Missing ⚠️
...ges/smooth_app/lib/pages/product/summary_card.dart 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6789       +/-   ##
============================================
- Coverage     9.54%    5.36%    -4.19%     
============================================
  Files          325      643      +318     
  Lines        16411   218735   +202324     
============================================
+ Hits          1567    11729    +10162     
- Misses       14844   207006   +192162     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@g123k
Copy link
Collaborator

g123k commented Jul 21, 2025

For the TabBar, I've fixed it in #6791

@PrimaelQuemerais
Copy link
Member Author

Thanks @g123k I'll remove my fix from here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 💬 To discuss and validate
Development

Successfully merging this pull request may close these issues.

3 participants