Skip to content

feat: 5817 Product page: tab Data (M3) #6692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

AdrienMDevMobile
Copy link
Contributor

What

  • feat 5814 : Product page: tab data
  • TODOs left :
  • getting nutritions Metrics
  • Edit element on click action

Screenshot

Screenshot 2024-12-09 at 15 58 00

Fixes bug(s)

  • Fixes:

Part of

Copy link
Collaborator

@g123k g123k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AdrienMDevMobile!

Some feedback about your PR:

  • Some categories are not clickable (eg: Labels & Certification)
  • Could you increase the clickable area around the Edit button? (+ Inkwell missing/invisible)
  • The design is not fully/always implemented:
    • Header colors + icon sizes
    • Height of items
    • Color of dividers
    • The expand button…
  • For nutrition facts, could you use the translations (already available in the app)
    IMG_5566D2CCDB9D-1

Additionally, could you please remove the Website tab and add a new section to the Raw data?
IMG_278763A285E8-1

@github-project-automation github-project-automation bot moved this from 💬 To discuss and validate to 🏗️ In Progress in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants