-
-
Notifications
You must be signed in to change notification settings - Fork 381
feat: Add More verbose proof display #6589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: Add More verbose proof display #6589
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6589 +/- ##
==========================================
- Coverage 9.54% 5.71% -3.84%
==========================================
Files 325 511 +186
Lines 16411 30514 +14103
==========================================
+ Hits 1567 1744 +177
- Misses 14844 28770 +13926 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hello @monsieurtanuki, |
@AshutoshKhadse23 Not 100%.
|
Can we press pause ?
I kind of liked the order and density @AshutoshKhadse23 was bringing, with aligned information. |
@AshutoshKhadse23 From now on please follow @teolemon's suggestions, comments and reviews on this PR. He has higher expectations regarding UI. |
@teolemon ,Ok then I will work on it and push the work as early as possible |
|
@teolemon, |
@teolemon,@monsieurtanuki |
@AshutoshKhadse23 how come all the locations are unknown ? Is it possible to add a proof without one ? @raphodn @TTalex |
Also, since we now have infinite scrolling, we probably don't need : "Latest 13 prices (total: 13) (2 2)" anymore |
@teolemon, ![]() |
Yes it is possible if you press done after the proof section is completed. |
Ok I will make the changes |
@AshutoshKhadse23 doesn't the API return online ? If so we should display online ? Otherwise, it might make sense to evolve the API. |
See this is the response I got from Proof class
|
Closes: #6588
Added: